Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADP-3392] Add run scripts and test for preview network #4795

Merged
merged 8 commits into from
Sep 27, 2024
Merged

[ADP-3392] Add run scripts and test for preview network #4795

merged 8 commits into from
Sep 27, 2024

Conversation

paolino
Copy link
Collaborator

@paolino paolino commented Sep 25, 2024 •
edited
Loading

  • Re-enable network synchronization CI checks by confining compilation of mithril where necessary. Mithril is not compiling ATM. The mithril test will soft fail in case of compilation error
  • Re-enable preprod full sync based on snapshot. Will soft fail if the snapshot is broken
  • Add a nix CI job to test we can connect to preview
  • Add a docker CI job to test we can full sync with preview
  • Remove 8093 as a default port for the deposit wallet

ADP-3392

@paolino paolino added the CI CI related label Sep 25, 2024
@paolino paolino self-assigned this Sep 25, 2024
@paolino paolino force-pushed the paolino/ADP-3392/add-preview-network-running-scripts branch from 3c588bd to 5fbadde Compare September 25, 2024 14:31
@paolino paolino marked this pull request as ready for review September 25, 2024 15:17
HeinrichApfelmus
HeinrichApfelmus approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@HeinrichApfelmus HeinrichApfelmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you! 😊

@paolino paolino added this pull request to the merge queue Sep 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 26, 2024
@paolino paolino added this pull request to the merge queue Sep 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 26, 2024
@paolino paolino force-pushed the paolino/ADP-3392/add-preview-network-running-scripts branch 3 times, most recently from 0096ea3 to 47fbbcb Compare September 27, 2024 14:18
@paolino paolino force-pushed the paolino/ADP-3392/add-preview-network-running-scripts branch from 47fbbcb to 6f79090 Compare September 27, 2024 14:21
@paolino paolino merged commit 1930cb3 into master Sep 27, 2024
26 checks passed
@paolino paolino deleted the paolino/ADP-3392/add-preview-network-running-scripts branch September 27, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeinrichApfelmus HeinrichApfelmus HeinrichApfelmus approved these changes

Assignees

@paolino paolino

Labels
CI CI related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paolino @HeinrichApfelmus